McPringle/fitpub
1
0
Fork 0
Code Issues 24 Pull requests 6 Projects Releases Packages Wiki Activity Actions

fix(analytics): rebuild achievements after activity deletion

Browse source 
Signed-off-by: Marcus Fihlon <marcus@fihlon.swiss>
This commit is contained in:
Marcus Fihlon 2026-04-29 10:00:09 +02:00
parent 10037de043
commit 2c567a5e8e
Signed by: McPringle
GPG key ID: C6B7F469EE363E1F
2 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/main/java/net/javahippie/fitpub/service/FitFileService.java
View file

@ -319,6 +319,7 @@ public class FitFileService {
return activityRepository.findByIdAndUserId(activityId, userId) return activityRepository.findByIdAndUserId(activityId, userId)
.map(activity -> { .map(activity -> {
activityRepository.delete(activity); activityRepository.delete(activity);
achievementService.rebuildAchievementsForUser(userId);
log.info("Deleted activity {} for user {}", activityId, userId); log.info("Deleted activity {} for user {}", activityId, userId);
return true; return true;
}) })

2
src/test/java/net/javahippie/fitpub/service/FitFileServiceTest.java
View file

@ -238,6 +238,7 @@ class FitFileServiceTest {
// Assert // Assert
assertTrue(result); assertTrue(result);
verify(activityRepository).delete(activity); verify(activityRepository).delete(activity);
verify(achievementService).rebuildAchievementsForUser(testUserId);
} }
@Test @Test
@ -254,6 +255,7 @@ class FitFileServiceTest {
// Assert // Assert
assertFalse(result); assertFalse(result);
verify(activityRepository, never()).delete(any()); verify(activityRepository, never()).delete(any());
verify(achievementService, never()).rebuildAchievementsForUser(any());
} }
@Test @Test