McPringle/fitpub
1
0
Fork 0
Code Issues 24 Pull requests 6 Projects Releases Packages Wiki Activity Actions

fix(analytics): show highest elevation gain in meters #35

Open
McPringle wants to merge 1 commit from McPringle/fix/elevation-gain-in-meters into main
pull from: McPringle/fix/elevation-gain-in-meters
merge into: McPringle:main
Conversation 0 Commits 1 Files changed 2 +9
McPringle commented 2026-04-30 13:05:59 +02:00 (Migrated from github.com)
Copy link

This PR fixes the analytics UI to display Highest Elevation Gain in meters instead of kilometers.

The value is already stored in meters. The issue was in frontend formatting, which treated all meters-based personal records as distance. This change keeps Longest Distance in kilometers while showing elevation gain correctly in meters, including the improvement text.

This PR fixes the analytics UI to display Highest Elevation Gain in meters instead of kilometers. The value is already stored in meters. The issue was in frontend formatting, which treated all meters-based personal records as distance. This change keeps Longest Distance in kilometers while showing elevation gain correctly in meters, including the improvement text.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin McPringle/fix/elevation-gain-in-meters:McPringle/fix/elevation-gain-in-meters
git checkout McPringle/fix/elevation-gain-in-meters

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff McPringle/fix/elevation-gain-in-meters
git checkout McPringle/fix/elevation-gain-in-meters
git rebase main
git checkout main
git merge --ff-only McPringle/fix/elevation-gain-in-meters
git checkout McPringle/fix/elevation-gain-in-meters
git rebase main
git checkout main
git merge --no-ff McPringle/fix/elevation-gain-in-meters
git checkout main
git merge --squash McPringle/fix/elevation-gain-in-meters
git checkout main
git merge --ff-only McPringle/fix/elevation-gain-in-meters
git checkout main
git merge McPringle/fix/elevation-gain-in-meters
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: McPringle/fitpub#35
No description provided.
Delete branch "McPringle/fix/elevation-gain-in-meters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?