McPringle/fitpub
1
0
Fork 0
Code Issues 24 Pull requests 6 Projects Releases Packages Wiki Activity Actions

Fix incorrect activity count in summaries #5

Open
kabupatix wants to merge 1 commit from kabupatix/summary-activity-count into main
pull from: kabupatix/summary-activity-count
merge into: McPringle:main
Conversation 2 Commits 1 Files changed 1 -1
kabupatix commented 2026-04-12 09:39:23 +02:00 (Migrated from github.com)
Copy link
No description provided.
McPringle commented 2026-04-28 17:02:37 +02:00 (Migrated from github.com)
Copy link

Easy solution, but after applying your patch the calculation becomes synchronous and may slow down imports and uploads.

I identified the root cause of the incorrect data: a potential race condition when activities are created in rapid succession. I have proposed a fix in PR #26.

Easy solution, but after applying your patch the calculation becomes synchronous and may slow down imports and uploads. I identified the root cause of the incorrect data: a potential race condition when activities are created in rapid succession. I have proposed a fix in PR #26.
McPringle commented 2026-04-30 11:43:37 +02:00 (Migrated from github.com)
Copy link

The current implementation of the analytics part is unnecessarily complicated and looks error prone. I would like to work on a simpler solution. See Issue #30.

The current implementation of the analytics part is unnecessarily complicated and looks error prone. I would like to work on a simpler solution. See Issue #30.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin kabupatix/summary-activity-count:kabupatix/summary-activity-count
git checkout kabupatix/summary-activity-count

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff kabupatix/summary-activity-count
git checkout kabupatix/summary-activity-count
git rebase main
git checkout main
git merge --ff-only kabupatix/summary-activity-count
git checkout kabupatix/summary-activity-count
git rebase main
git checkout main
git merge --no-ff kabupatix/summary-activity-count
git checkout main
git merge --squash kabupatix/summary-activity-count
git checkout main
git merge --ff-only kabupatix/summary-activity-count
git checkout main
git merge kabupatix/summary-activity-count
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: McPringle/fitpub#5
No description provided.
Delete branch "kabupatix/summary-activity-count"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?